From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: libkvm not compile with latest qemu-kvm
Date: Thu, 21 May 2009 14:56:59 +0300
Message-ID: <4A15418B.2070005@redhat.com>
References: <0463F45F3606F4428ED35AC8C709F92E0896145719@pdsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: "'kvm-devel'" <kvm@vger.kernel.org>
To: "Xu, Jiajun" <jiajun.xu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33104 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752748AbZEUL5B (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 21 May 2009 07:57:01 -0400
In-Reply-To: <0463F45F3606F4428ED35AC8C709F92E0896145719@pdsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Xu, Jiajun wrote:
> Hi Avi,
> I found libkvm.a not compiled with latest qemu-kvm with following err=
or message:
> ####
> gcc  -I. -I.. -I/home/jiajun/kvm/qemu-kvm/target-i386 -I/home/jiajun/=
kvm/qemu-kvm -MMD -MT qemu-kvm-helper.o -MP -DNEED_CPU_H -D_GNU_SOURCE =
-D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -D__user=3D -I/home/jiajun=
/kvm/qemu-kvm/tcg -I/home/jiajun/kvm/qemu-kvm/tcg/x86_64 -I/home/jiajun=
/kvm/qemu-kvm/fpu   -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/jiajun/kvm/q=
emu-kvm/slirp -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels =
-Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-de=
cls -I/home/jiajun/kvm/qemu-kvm/kvm/libkvm  -m64 -I/home/jiajun/kvm/qem=
u-kvm/kvm/include -I/home/jiajun/kvm/qemu-kvm/kvm/include/x86 -c -o qem=
u-kvm-helper.o /home/jiajun/kvm/qemu-kvm/qemu-kvm-helper.c
>   CC    x86_64-softmmu/kvm-tpr-opt.o
>   CC    x86_64-softmmu/disas.o
>   CC    x86_64-softmmu/i386-dis.o
>   CC    x86_64-softmmu/vl.o
>   CC    x86_64-softmmu/gdbstub-xml.o
> /home/jiajun/kvm/qemu-kvm/vl.c:4885: warning: =E2alloc_mem_area=E2 de=
fined but not used
>   AR    x86_64-softmmu/libqemu.a
>   LINK  x86_64-softmmu/qemu-system-x86_64
> gcc: libkvm.a: No such file or directory
> make[1]: *** [qemu-system-x86_64] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
> ####
>
> After I modified the Makefile.target, it can pass:
>
> diff --git a/Makefile.target b/Makefile.target
> index 575466c..78bf5d7 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -796,7 +796,7 @@ vl.o: qemu-options.h
>
>  $(QEMU_PROG): LIBS +=3D $(SDL_LIBS) $(COCOA_LIBS) $(CURSES_LIBS) $(B=
RLAPI_LIBS) $(VDE_LIBS)
>  $(QEMU_PROG): ARLIBS=3D../libqemu_common.a libqemu.a $(HWLIB)
> -$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB)
> +$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB) $(DEPLI=
BS)
>         $(call LINK,$(OBJS))
>
>  $(QEMU_PROG): ARLIBS +=3D $(DEPLIBS)
>
>  =20

Thanks, I've applied something similar (added the dependency in a=20
separate line to avoid future merge conflicts).

--=20
error compiling committee.c: too many arguments to function