From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 1 of 2] blkfront: sector size > 512
Date: Thu, 21 May 2009 14:17:11 +0100
Message-ID: <4A155457.7020205@eu.citrix.com>
References: <4A153DC4.5070803@eu.citrix.com>
	<20090521120849.GA5806@const.famille.thibault.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090521120849.GA5806@const.famille.thibault.fr>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Samuel Thibault wrote:

> Stefano Stabellini, le Thu 21 May 2009 12:40:52 +0100, a =C3=A9crit :
>> The first and last sector as well as the sector number of the request =
is
>> expressed in 512 bytes units, independently from the real sector size.
>>      req->id =3D (uintptr_t) aiocbp;
>> -    req->sector_number =3D aiocbp->aio_offset / dev->info.sector_size=
;
>> +    req->sector_number =3D aiocbp->aio_offset / 512;
>> =20
>=20
> Oh?!
>=20
> That needs to be better documented in xen/include/public/io/blkif.h,
> then.  I'm however wondering whether this shouldn't actually be fixed i=
n
> the blkback/cdrom interface instead.
>=20

Yeah, I am surprised as you are, but the linux blkfront does the same
thing so I prefer to avoid changing the protocol now.