From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Garzik <jeff@garzik.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
open-osd mailing-list <osd-dev@open-osd.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 2/2] osdblk: Adjust queue limits to lower device's limits
Date: Thu, 21 May 2009 17:11:28 +0300 [thread overview]
Message-ID: <4A156110.3080900@panasas.com> (raw)
In-Reply-To: <4A155FF6.3060005@panasas.com>
call blk_queue_stack_limits() to copy queue limits from
the underline osd scsi_device. This is absolutely needed
because osdblk cannot sleep when allocating a lower-request and
therefore cannot be bouncing.
TODO: Dynamic changes of limits to the lower device queue
will not reflect in the upper driver
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
drivers/block/osdblk.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/block/osdblk.c b/drivers/block/osdblk.c
index 531d234..0da8ce0 100644
--- a/drivers/block/osdblk.c
+++ b/drivers/block/osdblk.c
@@ -66,6 +66,7 @@
#include <scsi/osd_initiator.h>
#include <scsi/osd_attributes.h>
#include <scsi/osd_sec.h>
+#include <scsi/scsi_device.h>
#define DRV_NAME "osdblk"
#define PFX DRV_NAME ": "
@@ -410,6 +411,12 @@ static int osdblk_init_disk(struct osdblk_device *osdev)
return rc;
}
+ /* Set our limits to the lower device limits, because osdblk cannot
+ * sleep when allocating a lower-request and therefore cannot be
+ * bouncing.
+ */
+ blk_queue_stack_limits(q, osd_request_queue(osdev->osd));
+
blk_queue_prep_rq(q, blk_queue_start_tag);
blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, osdblk_prepare_flush);
--
1.6.2.1
next prev parent reply other threads:[~2009-05-21 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 14:06 [PATCH 0/2 version 4] osdblk: a Linux block device for OSD objects Boaz Harrosh
2009-05-21 14:09 ` [PATCH 1/2 " Boaz Harrosh
2009-05-21 14:11 ` Boaz Harrosh [this message]
2009-05-21 22:41 ` [PATCH 0/2 " Jeff Garzik
2009-05-26 7:43 ` Boaz Harrosh
2009-05-28 22:31 ` Jeff Garzik
2009-05-31 9:50 ` Boaz Harrosh
2009-06-10 12:52 ` Jeff Garzik
2009-06-10 13:33 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A156110.3080900@panasas.com \
--to=bharrosh@panasas.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.