All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stephen Boyd <bebarino@gmail.com>,
	git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
	Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCHv2 1/2] parse-options: add PARSE_OPT_LITERAL_ARGHELP for complicated argh's
Date: Thu, 21 May 2009 18:51:51 +0200	[thread overview]
Message-ID: <4A1586A7.9000909@lsrfire.ath.cx> (raw)
In-Reply-To: <7v3aaybewo.fsf@alter.siamese.dyndns.org>

Junio C Hamano schrieb:
> Stephen Boyd <bebarino@gmail.com> writes:
> 
>> I've decided to appease the pirate haters :-)
> 
> Hmmm, why does this break t0040 (I am queuing this on top of 5acb3e5)?

Probably because it changes this:

	pos += fprintf(...);

into this (simplified, usage_argh() expanded):

	pos += pos + fprintf(...);

usage_argh() doesn't need the parameter pos.

René

  reply	other threads:[~2009-05-21 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17 10:47 [PATCH 1/3] show-branch: Fix die message in parse_reflog_param() Stephen Boyd
2009-05-17 10:47 ` [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's Stephen Boyd
2009-05-17 10:47   ` [PATCH 3/3] show-branch: migrate to parse-options API Stephen Boyd
2009-05-18  6:14   ` [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's Junio C Hamano
2009-05-18  7:08     ` Stephen Boyd
2009-05-18  7:57       ` Junio C Hamano
2009-05-18  8:06         ` Stephen Boyd
2009-05-18 22:52           ` Jakub Narebski
2009-05-19  5:09             ` Sverre Rabbelier
2009-05-21  7:33 ` [PATCHv2 1/2] parse-options: add PARSE_OPT_LITERAL_ARGHELP " Stephen Boyd
2009-05-21  7:33   ` [PATCHv2 2/2] show-branch: migrate to parse-options API Stephen Boyd
2009-05-21 16:26   ` [PATCHv2 1/2] parse-options: add PARSE_OPT_LITERAL_ARGHELP for complicated argh's Junio C Hamano
2009-05-21 16:51     ` René Scharfe [this message]
2009-05-21 19:03       ` Stephen Boyd
2009-05-21 21:27         ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1586A7.9000909@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.