[Qemu-devel] Re: [PATCH] augment info migrate with page status

[Anthony Liguori <aliguori@us.ibm.com>]

Glauber Costa wrote:
> This patch augments info migrate output with status about:
> * ram bytes remaining
> * ram bytes transferred
> * ram bytes total
>
> This should be enough for management tools to realize
> whether or not there is progress in migration. We can
> add more information later on, if the need arrives
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  migration.c |    3 +++
>  sysemu.h    |    4 ++++
>  vl.c        |   21 ++++++++++++++++++++-
>  3 files changed, 27 insertions(+), 1 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index b9e3368..a771f37 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -116,6 +116,9 @@ void do_info_migrate(Monitor *mon)
>          switch (s->get_status(s)) {
>          case MIG_STATE_ACTIVE:
>              monitor_printf(mon, "active\n");
> +            monitor_printf(mon, "transferred ram: %lu kbytes\n", ram_bytes_transferred() >> 10);
> +            monitor_printf(mon, "remaining ram: %lu kbytes\n", ram_bytes_remaining() >> 10);
> +            monitor_printf(mon, "total ram: %lu kbytes\n", ram_bytes_total() >> 10);
>   

ram_addr_t isn't %lu.  It's 64-bit.  There's a PRI macro somewhere for it...

-- 
Regards,

Anthony Liguori