Stefan Weil wrote: > Anthony Liguori schrieb: >> Stefan Weil wrote: >>> Add new function qemu_register_machines. >>> >>> The patch removes the unused prototype register_machines >>> and adds a new function which makes registration of >>> more than one machine a little easier. >>> >>> The new function is applied to the machines in hw/spitz.c >>> (where a static keyword for akitapda_machine was missing), >>> but it can also be applied to several other QEMU source files. >>> >>> Signed-off-by: Stefan Weil >>> >> Might as well eliminate qemu_register_machine() and convert everything >> to use qemu_register_machines(). >> > > Yes. But I prefer to have both interfaces. > qemu_register_machine(&my_machine) looks nicer > than qemu_register_machines(&my_machine, 1). > static inline void qemu_register_machine(QEMUMachine *m) { qemu_register_machines(m, 1); } BTW, this is also a good chance to drop the now unused return value. Jan