From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M7FN3-00025S-CR for mharc-grub-devel@gnu.org; Thu, 21 May 2009 17:00:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7FN1-000254-GF for grub-devel@gnu.org; Thu, 21 May 2009 17:00:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7FMw-00024B-0M for grub-devel@gnu.org; Thu, 21 May 2009 17:00:06 -0400 Received: from [199.232.76.173] (port=35989 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7FMv-000247-SD for grub-devel@gnu.org; Thu, 21 May 2009 17:00:01 -0400 Received: from mailout08.t-online.de ([194.25.134.20]:50587) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7FMv-0003VK-Dg for grub-devel@gnu.org; Thu, 21 May 2009 17:00:01 -0400 Received: from fwd03.aul.t-online.de by mailout08.sul.t-online.de with smtp id 1M7FMt-0007la-01; Thu, 21 May 2009 22:59:59 +0200 Received: from [10.3.2.2] (rfJ0jOZYrh04VqB+38kApNkWa4+kcLSL9-ohqUgRTzd+2K8tFY-nry1KPNWtpVOgvx@[217.235.192.77]) by fwd03.aul.t-online.de with esmtp id 1M7FMi-0MjYhM0; Thu, 21 May 2009 22:59:48 +0200 Message-ID: <4A15C0C5.6070708@t-online.de> Date: Thu, 21 May 2009 22:59:49 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090403 SeaMonkey/1.1.16 MIME-Version: 1.0 To: The development of GRUB 2 References: <1242689772.16522.1.camel@mj> <1242692278.26306.3.camel@mj> <1M6P7a-0SfD5U0@fwd04.aul.t-online.de> <4A1478C1.5000906@t-online.de> <1242857580.2555.2.camel@mj> In-Reply-To: <1242857580.2555.2.camel@mj> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: rfJ0jOZYrh04VqB+38kApNkWa4+kcLSL9-ohqUgRTzd+2K8tFY-nry1KPNWtpVOgvx X-TOI-MSGID: f061f7c2-3115-4deb-9ebd-7ae33494f6df X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] ata.mod under qemu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2009 21:00:07 -0000 Pavel Roskin wrote: > On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote: > >> The attached patch should fix this. It should also prevents misleading >> error messages if a device does not exist. >> > It helps detect CD-ROM under qemu. But on the real hardware, it > introduces ghost drives. > > Without the patch, I have (ata7) for the SATA hard drive. With the > patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW > and two bogus unreadable drives (ata0) and (ata1). > > Thanks for this test. I could not reproduce this yet. I presume that the controller behind (ata0) and (ata1) is the chipset's PATA controller. If no device is connected, these controllers often echo a write to (e.g. command) register address back to the next read of (e.g. status) register address if the time between is too short. (No VM emulates this behavior :-) Could you possibly repeat this test with 'debug=ata' enabled? If this removes the bogus drives, it is likely a problem of too short wait times. I will prepare a new patch with longer timeouts and more thorough register tests during identify. -- Regards, Christian Franke