Re: ath/regd.c: regdomain 0x8000 fails to retrieve a regulatory domain pair

[Joerg Albert <jal2@gmx.de>]

On 05/21/2009 07:16 PM, Luis R. Rodriguez wrote:

> Joerg, can you please try this patch, its just informative and I would
> like to see the output. A regulatory domain in the EEPROM set to 0x8000 
> should be cought, as you indicated, in this code:
> 
>         if (reg->country_code == CTRY_DEFAULT &&
>             regdmn == CTRY_DEFAULT)
>                 reg->country_code = CTRY_UNITED_STATES;
> 
> The debug prints should help.
 > ...
With the patch I get:

usb 1-5: firmware: requesting ar9170-2.fw
ath: EEPROM indicates we should expect a country code
ath: No regulatory domain pair found, cannot continue
ar9170usb: probe of 1-5:1.0 failed with error -22

IMHO the in the above if-statement regdmn == 0x8000 (as read from 
the EEPROM by ath_regd_get_eepromRD), but CTRY_DEFAULT is defined as 
zero, so reg->country_code isn't set.
Shouldn't we say "regdmn == (CTRY_DEFAULT|COUNTRY_ERD_FLAG)",because 
without the ERD flag set we cannot compare a regdomain with a 
country code?

/Joerg