All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Jens Axboe <Jens.Axboe@oracle.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] block: fix oops with block tag queueing
Date: Fri, 22 May 2009 08:23:03 +0900	[thread overview]
Message-ID: <4A15E257.9010907@gmail.com> (raw)
In-Reply-To: <4A15858A.5000906@panasas.com>

Boaz Harrosh wrote:
> On 05/21/2009 04:55 AM, Tejun Heo wrote:
>> James Bottomley wrote:
>> There are also some drivers which use queuelist for internal purposes
>> after dequeueing, which also screws up blk_queued_rq() test in
>> addition to being questionable practice to begin with.  Maybe we would
>> be better off with a flag?
>>
> 
> What is the REQ_STARTED flag for?

That is used to pin a request which has been peeked by low level
driver at the top of the queue so that the next peek or fetch returns
the same request.  I'm not sure whether that is necessary at this
point tho.

Thanks.

-- 
tejun

  reply	other threads:[~2009-05-21 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 17:06 [PATCH] block: fix oops with block tag queueing James Bottomley
2009-05-21  1:55 ` Tejun Heo
2009-05-21 16:47   ` Boaz Harrosh
2009-05-21 23:23     ` Tejun Heo [this message]
2009-05-26 15:58   ` James Bottomley
2009-05-26 22:53     ` Tejun Heo
2009-05-27  4:27       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A15E257.9010907@gmail.com \
    --to=htejun@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Jens.Axboe@oracle.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.