Re: [PATCH 1 of 2] blkfront: sector size > 512

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

Keir Fraser wrote:

> 
> Yeah, I'd take a patch to add a nice clear comment about this to blkif.h.
> ;-)
> 



Is this comment clear enough?

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---


diff -r 61404d971c92 xen/include/public/io/blkif.h
--- a/xen/include/public/io/blkif.h	Thu May 21 04:31:47 2009 +0100
+++ b/xen/include/public/io/blkif.h	Fri May 22 15:29:19 2009 +0100
@@ -84,6 +84,13 @@
  */
 #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11
 
+/* 
+ * first_sect and last_sect in blkif_request_segment, as well as
+ * sector_number in blkif_request are all expressed in 512 bytes units,
+ * however they must be properly aligned to the real sector size of
+ * the physical disk (as reported in the "sector-size" node in backend
+ * xenbus info).
+ */
 struct blkif_request_segment {
     grant_ref_t gref;        /* reference to I/O buffer frame        */
     /* @first_sect: first sector in frame to transfer (inclusive).   */