All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Smith <msmith@cbnco.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: amend-recipes.inc
Date: Fri, 22 May 2009 16:35:53 -0400	[thread overview]
Message-ID: <4A170CA9.10402@cbnco.com> (raw)
In-Reply-To: <DEB73D04-3490-41E1-8C56-C41822C040D9@mvista.com>

Hi Chris,

This works for me. I can put multiple recipes dirs in my COLLECTIONS, 
set FILESPATHBASE to reference them all, and create a busybox/amend.inc 
under any of my COLLECTIONS dirs.

There is something strange going on: when I require amend-recipes.inc in 
my distro config, and the cache is rebuilt, I see deprecation warnings 
about base_set_filespath that weren't printing before. If I comment out 
the require line and let bb rebuild the cache, the warnings go away.

About 45 recipes are using base_set_filespath, including glibc, 
e2fsprogs-native, and many others. I don't see why the warnings don't 
show up normally if amend-recipes is not included. It looks to me like 
they would always print, but they don't.

My FILESPATHBASE is set to:

FILESPATHBASE =. "${@ \
         ':'.join([os.path.join(recipedir, \
                         os.path.basename(os.path.dirname( \
                                                 d.getVar('FILE', 1)))) 
\                for recipedir in d.getVar('COLLECTIONS', 1).split()])}:"

and COLLECTIONS is just a list of a few recipes directories, with 
oe/recipes last.

Mike

Christopher Larson wrote:
> I created a little .inc that can be loaded into a distro .conf.  It just 
> enables the ability to amend bits to a recipe from its filespath.  I 
> mentioned this in a previous email wrt managing overlays.  It's 
> incredibly simple, but I'd like a sanity check :)  It seems to work fine 
> in my local test builds.
> 
> python () {
>     import bb
>     amendfile = bb.which(d.getVar("FILESPATH", 1), "amend.inc")
>     if amendfile:
>         bb.parse.handle(amendfile, d, 1)
> }




  reply	other threads:[~2009-05-22 20:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 18:20 amend-recipes.inc Christopher Larson
2009-05-22 20:35 ` Michael Smith [this message]
2009-05-22 20:50   ` amend-recipes.inc Christopher Larson
2009-05-22 21:32     ` amend-recipes.inc Michael Smith
2009-05-26  6:28     ` amend-recipes.inc Michael Smith
2009-05-26  6:34       ` [PATCH 1/4] Remove references to base_set_filespath() from recipes that don't need it Michael Smith
2009-05-26  6:34         ` [PATCH 2/4] Replace obsolete base_set_filespath() with FILESPATHPKG in some recipes Michael Smith
2009-05-26  6:34           ` [PATCH 3/4] glibc/eglibc: remove calls to obsolete base_set_filespath() Michael Smith
2009-05-26  6:34             ` [PATCH 4/4] uclibc: " Michael Smith
2009-05-30 16:42               ` Tom Rini
2009-05-30 16:42             ` [PATCH 3/4] glibc/eglibc: " Tom Rini
2009-05-30 16:42           ` [PATCH 2/4] Replace obsolete base_set_filespath() with FILESPATHPKG in some recipes Tom Rini
2009-05-30  0:48         ` [PATCH 1/4] Remove references to base_set_filespath()from recipes that don't need it Michael Smith
2009-05-30  5:29           ` Chris Larson
2009-05-30 17:32             ` Tom Rini
2009-05-30 16:42         ` [PATCH 1/4] Remove references to base_set_filespath() from " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A170CA9.10402@cbnco.com \
    --to=msmith@cbnco.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.