All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 V2] mips: unify lds
Date: Sun, 24 May 2009 00:45:22 +0900	[thread overview]
Message-ID: <4A181A12.8050502@pobox.com> (raw)
In-Reply-To: <1243078501-27652-2-git-send-email-plagnioj@jcrosoft.com>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> all mips boards except a few use the same cpu lds so move it to cpu/$(CPU)
> 
> that could be overwrite in following order
> SOC
> BOARD
> via the corresponding config.mk
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Looks good, except for one nit.

> diff --git a/board/micronas/vct/u-boot.lds b/cpu/mips/u-boot.lds
> similarity index 75%
> rename from board/micronas/vct/u-boot.lds
> rename to cpu/mips/u-boot.lds
> index b90b186..dda0dda 100644
> --- a/board/micronas/vct/u-boot.lds
> +++ b/cpu/mips/u-boot.lds
> @@ -1,5 +1,8 @@
>  /*
> - * (C) Copyright 2003
> + * (C) Copyright 2004
> + * Masami Komiya <mkomiya@sonare.it>
> + *
> + * (C) Copyright 2003-2005
>   * Wolfgang Denk Engineering, <wd@denx.de>
>   *
>   * See file CREDITS for list of people who contributed to this

You probably just referred to the tb0229/u-boot.lds, but we'd like to
see here Wolfgang first.

  Shinya

  reply	other threads:[~2009-05-23 15:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 20:56 [U-Boot] [PATCH 1/1] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-10 21:34 ` Wolfgang Denk
2009-05-16  3:59   ` Shinya Kuribayashi
2009-05-16  4:02     ` Shinya Kuribayashi
2009-05-22 23:48     ` [U-Boot] *** PROBABLY SPAM *** " Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 11:35     ` [U-Boot] [PATCH 1/2 V2] mips: add endianness support Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 11:35       ` [U-Boot] [PATCH 2/2 V2] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 15:45         ` Shinya Kuribayashi [this message]
2009-05-23 15:24       ` [U-Boot] [PATCH 1/2 V2] mips: add endianness support Shinya Kuribayashi
2009-05-23 15:19         ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 17:58           ` Shinya Kuribayashi
2009-05-23 19:41             ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42             ` [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42               ` [U-Boot] [PATCH 2/3] mips: add endianness support Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42                 ` [U-Boot] [PATCH 3/3] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-31 22:27                   ` Wolfgang Denk
2009-05-31 22:26                 ` [U-Boot] [PATCH 2/3] mips: add endianness support Wolfgang Denk
2009-05-23 22:28               ` [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile Wolfgang Denk
2009-05-24 15:18                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 17:13                   ` Wolfgang Denk
2009-06-23 14:34               ` Shinya Kuribayashi
2009-06-23 15:14                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 15:40                   ` Shinya Kuribayashi
2009-06-23 21:26                     ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 17:07               ` Mike Frysinger
2009-06-23 17:33                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-10 22:35                 ` Wolfgang Denk
2009-07-11  3:18                   ` Mike Frysinger
2009-07-17 19:18               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A181A12.8050502@pobox.com \
    --to=skuribay@pobox.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.