From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat
 objects
Date: Sun, 24 May 2009 11:15:26 +0300
Message-ID: <4A19021E.8080205@redhat.com>
References: <4A170535.3090007@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:42576 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751387AbZEXIP2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 24 May 2009 04:15:28 -0400
In-Reply-To: <4A170535.3090007@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Jan Kiszka wrote:
> This redundancy breaks subtly when building against recent OpenSUSE
> kernels.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
>  x86/Kbuild |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/x86/Kbuild b/x86/Kbuild
> index e304c79..ade87fc 100644
> --- a/x86/Kbuild
> +++ b/x86/Kbuild
> @@ -13,7 +13,7 @@ endif
>  ifeq ($(CONFIG_IOMMU_API),y)
>  kvm-objs += iommu.o
>  endif
> -kvm-intel-objs := vmx.o vmx-debug.o ../external-module-compat.o
> -kvm-amd-objs := svm.o ../external-module-compat.o
> +kvm-intel-objs := vmx.o vmx-debug.o
> +kvm-amd-objs := svm.o
>  
>   

IIRC, for really old kernels, some symbols are defined in 
external-module-compat.c and needed by kvm-$arch.ko.  So we'll have to 
export those symbols if we drop the double link (which is a good idea 
regardless of the build problem).

-- 
error compiling committee.c: too many arguments to function