From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects Date: Sun, 24 May 2009 11:17:46 +0300 Message-ID: <4A1902AA.4070204@redhat.com> References: <4A170535.3090007@web.de> <20090523013659.GH20823@sequoia.sous-sol.org> <4A17E431.1010105@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Cc: Chris Wright , kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58088 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbZEXISk convert rfc822-to-8bit (ORCPT ); Sun, 24 May 2009 04:18:40 -0400 In-Reply-To: <4A17E431.1010105@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Chris Wright wrote: > >> * Jan Kiszka (jan.kiszka@web.de) wrote: >> >>> This redundancy breaks subtly when building against recent OpenSUSE >>> kernels. >>> >> What breaks? >> > > When building external-module-compat.c, linux/scripts/basic/hash somehow > gets called with a multi-word modname. It complains via its usage, and > gcc then tries to compile files it derives from that output: > > gcc -Wp,-MD,/data/kvm-kmod/x86/../.external-module-compat.o.d -nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/4.3/include -D__KERNEL__ -I/data/kvm-kmod/include -Iinclude -Iinclude2 -I/lib/modules/2.6.27.21-0.1-default/source/include -Iarch/x86/include -I/data/kvm-kmod/include-compat -include include/linux/autoconf.h -include /data/kvm-kmod/x86/external-module-compat.h -I/data/kvm-kmod/x86 -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Os -m64 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -pipe -Wno-sign-compare -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -I/usr/src/linux-2.6.27.21-0.1/include/asm-x86/mach- default -Iinclude/asm-x86/mach-default -fno-stack-protector -fomit-frame-pointer -fasynchronous-unwind-tables -g -Wdeclaration-after-statement -Wno-pointer-sign -fwrapv -DMODULE -D"KBUILD_STR( > s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(external_module_compat)" -D"DEBUG_HASH=Usage: ./scripts/basic/hash " -D"DEBUG_HASH2=Usage: ./scripts/basic/hash " -c -o /data/kvm-kmod/x86/../.tmp_external-module-compat.o /data/kvm-kmod/x86/../external-module-compat.c > gcc: : Datei oder Verzeichnis nicht gefunden > gcc: : Datei oder Verzeichnis nicht gefunden > gcc: : Datei oder Verzeichnis nicht gefunden > gcc: : Datei oder Verzeichnis nicht gefunden > > Can you show the call to hash? It's more interesting than the aftermath of its failure. -- error compiling committee.c: too many arguments to function