From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] run vnc without sdl
Date: Sun, 24 May 2009 14:03:51 +0300 [thread overview]
Message-ID: <4A192997.6090405@redhat.com> (raw)
In-Reply-To: <4A15CE70.7030201@us.ibm.com>
Anthony Liguori wrote:
> Glauber Costa wrote:
>> commit f92f8afebe038a4eae9ad90a140c9529f94919a6
>> "Eliminate --disable-gfx-check and make VNC default when SDL not
>> available"
>> broke usage of vnc. Passing -vnc <something> now fails because it
>> cannot initialize
>> SDL.
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>>
>
> What do you think about the attached? My goal with the original
> refactoring was to more cleanly separate things that's why I didn't
> want to introduce the !vnc_display.
>
> Ideally, we could make the various display states register themselves
> and completely eliminate the #ifdefs...
>
IMO we should not mix bug fixes with refactoring. Ideally Glauber's fix
should have been committed followed by this patch. If the refactoring
introduces a new regression, we can then safely revert it.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-24 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 18:21 [Qemu-devel] [PATCH] run vnc without sdl Glauber Costa
2009-05-21 21:58 ` [Qemu-devel] " Anthony Liguori
2009-05-21 22:19 ` Glauber Costa
2009-05-24 11:03 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A192997.6090405@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.