From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_ and dev_ Date: Sun, 24 May 2009 22:00:23 +0400 Message-ID: <4A198B37.1070100@ru.mvista.com> References: <57f9dd5c33bcdd863793a3ee95ab050e8456bab4.1243062772.git.joe@perches.com> <4A19399B.8060207@ru.mvista.com> <1243183596.3560.19.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:14726 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752856AbZEXR7Y (ORCPT ); Sun, 24 May 2009 13:59:24 -0400 In-Reply-To: <1243183596.3560.19.camel@Joe-Laptop.home> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Joe Perches Cc: Bartlomiej Zolnierkiewicz , Borislav Petkov , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Joe Perches wrote: >>>- dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 " >>>- "bytes\n", s, packet_size); >>>+ dev_err(&drive->gendev, >>>+ "%s: packet size (0x%02x) is not 12 bytes\n", >> When the message is broken by the format specifier, turning it into >>one liner can hardly help seraching... > grep "is not 12 bytes" Yes, carrying "is not 12 " to that would have made sense. >> Oh noes, the indentation... > trade-offs... >>>+ "(IO,CoD != (0,1) while issuing a packet command, retrying\n"); >> Sigh... > You seem to sigh a lot. ;) I'm not sure you'll like "ugh" better. >>>+ "unexpected interrupt, status=0x%02x, count=%ld\n", >> Hardly won anything... >> >>>+ "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n", >> >> Will you really use the full message to serch here? >> >>>+ "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n", >> >> Same comment about the line broken by the format specifiers. This >>wins absolutely nothing. > grep "STATUS.*ALTSTATUS" Hm, I didn't think about wildcards. Yet I find search for "probing with STATUS" more probable. >>>+ "no response (status = 0x%02x), resetting drive\n", >> >> And again... > grep "response.*resetting" I'd grep for "no response (status =" in this case. > cheers, Joe MBR, Sergei