From: Eric Dumazet <dada1@cosmosbay.com>
To: Benjamin LaHaise <bcrl@lhnet.ca>
Cc: Denys Fedoryschenko <denys@visp.net.lb>, netdev@vger.kernel.org
Subject: Re: regression: unregister_netdev() unusably slow
Date: Mon, 25 May 2009 00:07:07 +0200 [thread overview]
Message-ID: <4A19C50B.9040304@cosmosbay.com> (raw)
In-Reply-To: <20090524214433.GH24757@kvack.org>
Benjamin LaHaise a écrit :
> On Sun, May 24, 2009 at 11:42:17PM +0200, Eric Dumazet wrote:
>> (But vlan case might be litle bit more expensive than your case, since we call
>> synchronize_net() three times (once in unregister_vlan_dev(), and twice in rollback_registered()
>
> I did try commenting out the synchronize_net() calls in rollback_registered(),
> but that had almost no effect on the rate of interface deletion. 50ms is
> still way too expensive.
>
> -ben
Maybe your HZ is too low ? Changing to 1000 HZ helps a lot
Also your hotplug config might do strange things at device removal ?
What distro do you use ?
next prev parent reply other threads:[~2009-05-24 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 19:21 regression: unregister_netdev() unusably slow Benjamin LaHaise
2009-05-24 21:23 ` Denys Fedoryschenko
2009-05-24 21:37 ` Benjamin LaHaise
2009-05-24 21:42 ` Eric Dumazet
2009-05-24 21:44 ` Benjamin LaHaise
2009-05-24 22:07 ` Eric Dumazet [this message]
2009-05-24 22:12 ` Benjamin LaHaise
2009-05-24 22:47 ` Eric Dumazet
2009-05-25 0:00 ` Benjamin LaHaise
2009-05-25 5:22 ` Eric Dumazet
2009-05-25 8:04 ` Damien Wyart
2009-05-25 16:21 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A19C50B.9040304@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=bcrl@lhnet.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.