From: Avi Kivity <avi@redhat.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable before using it
Date: Mon, 25 May 2009 08:21:32 +0300 [thread overview]
Message-ID: <4A1A2ADC.1090004@redhat.com> (raw)
In-Reply-To: <1243228626.3157.4.camel@localhost.localdomain>
Jaswinder Singh Rajput wrote:
>> It's a false alarm. Isn't there a macro to shut up the warning?
>>
>>
>
> In arch/x86/kvm/paging_tmpl.h sptep is initialize only in :
>
> for_each_shadow_entry(vcpu, addr, iterator) {
>
> If we skip this, then we end up with wild sptep and returning it.
>
> Do you still think it is a false alarm ?
>
That loop always has at least one iteration.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-05-25 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 4:29 [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable before using it Jaswinder Singh Rajput
2009-05-24 12:21 ` Avi Kivity
2009-05-25 5:17 ` Jaswinder Singh Rajput
2009-05-25 5:21 ` Avi Kivity [this message]
2009-05-25 5:37 ` Jaswinder Singh Rajput
2009-05-25 6:01 ` Avi Kivity
2009-05-25 6:05 ` Ingo Molnar
2009-05-26 11:44 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1A2ADC.1090004@redhat.com \
--to=avi@redhat.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.