From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects Date: Mon, 25 May 2009 08:49:03 +0200 Message-ID: <4A1A3F5F.1030000@web.de> References: <4A170535.3090007@web.de> <20090523013659.GH20823@sequoia.sous-sol.org> <4A17E431.1010105@web.de> <4A1902AA.4070204@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB4BEDAF967734F6689FCE504" Cc: Chris Wright , kvm-devel To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:48949 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbZEYGtP (ORCPT ); Mon, 25 May 2009 02:49:15 -0400 In-Reply-To: <4A1902AA.4070204@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB4BEDAF967734F6689FCE504 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Jan Kiszka wrote: >> Chris Wright wrote: >> =20 >>> * Jan Kiszka (jan.kiszka@web.de) wrote: >>> =20 >>>> This redundancy breaks subtly when building against recent OpenSUSE >>>> kernels. >>>> =20 >>> What breaks? >>> =20 >> >> When building external-module-compat.c, linux/scripts/basic/hash someh= ow >> gets called with a multi-word modname. It complains via its usage, and= >> gcc then tries to compile files it derives from that output: >> >> gcc -Wp,-MD,/data/kvm-kmod/x86/../.external-module-compat.o.d=20 >> -nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/4.3/include >> -D__KERNEL__ -I/data/kvm-kmod/include -Iinclude -Iinclude2 >> -I/lib/modules/2.6.27.21-0.1-default/source/include=20 >> -Iarch/x86/include -I/data/kvm-kmod/include-compat -include >> include/linux/autoconf.h -include >> /data/kvm-kmod/x86/external-module-compat.h -I/data/kvm-kmod/x86 >> -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing >> -fno-common -Werror-implicit-function-declaration -Os -m64 >> -mtune=3Dgeneric -mno-red-zone -mcmodel=3Dkernel -funit-at-a-time >> -maccumulate-outgoing-args -DCONFIG_AS_CFI=3D1 >> -DCONFIG_AS_CFI_SIGNAL_FRAME=3D1 -pipe -Wno-sign-compare -mno-sse >> -mno-mmx -mno-sse2 -mno-3dnow >> -I/usr/src/linux-2.6.27.21-0.1/include/asm-x86/mach-default >> -Iinclude/asm-x86/mach-default -fno-stack-protector >> -fomit-frame-pointer -fasynchronous-unwind-tables -g >> -Wdeclaration-after-statement -Wno-pointer-sign -fwrapv -DMODULE >> -D"KBUILD_STR( >> s)=3D#s" -D"KBUILD_BASENAME=3DKBUILD_STR(external_module_compat)"=20 >> -D"DEBUG_HASH=3DUsage: ./scripts/basic/hash " >> -D"DEBUG_HASH2=3DUsage: ./scripts/basic/hash " -c -= o >> /data/kvm-kmod/x86/../.tmp_external-module-compat.o >> /data/kvm-kmod/x86/../external-module-compat.c >> gcc: : Datei oder Verzeichnis nicht gefunden >> gcc: : Datei oder Verzeichnis nicht gefunden >> gcc: : Datei oder Verzeichnis nicht gefunden >> gcc: : Datei oder Verzeichnis nicht gefunden >> >> =20 >=20 > Can you show the call to hash? It's more interesting than the aftermat= h > of its failure. >=20 strace said eg.: execve("./scripts/basic/hash", ["./scripts/basic/hash", "djb2", "/data/kvm-kmod/x86/..kvm", "kvm-amd", "kvm-intel"], ... Jan --------------enigB4BEDAF967734F6689FCE504 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoaP18ACgkQniDOoMHTA+mlpgCfTl/TsuFGxmyTDiiKsfi0DXW3 2tcAn1fh7rbJb8HydrKmOCMeAnv7rZ1A =/N9b -----END PGP SIGNATURE----- --------------enigB4BEDAF967734F6689FCE504--