From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] kvm-kmod: x86: Drop duplicate external-module-compat objects Date: Mon, 25 May 2009 12:36:05 +0300 Message-ID: <4A1A6685.2060602@redhat.com> References: <4A170535.3090007@web.de> <4A19021E.8080205@redhat.com> <4A1A412E.2090106@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33614 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbZEYJgG (ORCPT ); Mon, 25 May 2009 05:36:06 -0400 In-Reply-To: <4A1A412E.2090106@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Checked against 2.6.18 (2.6.16 doesn't build build with my gcc-4.3 and > x86/x86_emulate.o sends my gcc-3.3 into some stack overflow): We only > need to export kvm_smp_call_function_single. > > More patches to fix various old kernel build breakages are now also in > my queue... > > ------------> > > This redundancy breaks subtly when building against recent OpenSUSE > kernels. Somehow scripts/basic/hash gets called with multiple modname > arguments, causing it to fail and produce invalid output. > > Changes in v2: > - export kvm_smp_call_function_single required by vendor module > Applied, thanks. -- error compiling committee.c: too many arguments to function