All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Lublin <uril@redhat.com>
To: supriya kannery <supriyak@in.ibm.com>
Cc: Michael Goldish <mgoldish@redhat.com>, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST] [PATCH] Iterate over reboot
Date: Mon, 25 May 2009 14:21:25 +0300	[thread overview]
Message-ID: <4A1A7F35.8000600@redhat.com> (raw)
In-Reply-To: <49FEDACC.9000605@in.ibm.com>

On 05/04/2009 03:08 PM, supriya kannery wrote:

A commit-message is useful here.

> Signed-off-by: Supriya Kannery<supriyak@in.ibm.com>
> Cc : Michael Goldish<mgoldish@redhat.com>
>
 > --- kvm-autotest-tap/client/tests/kvm_runtest_2/control	2009-05-04 
17:03:20.000000000 +0530
 > +++ kvm-autotest-tap/client/tests/kvm_runtest_2/control.mod	2009-05-04 
17:02:52.000000000 +0530
 > @@ -99,7 +99,8 @@ for dict in list:
 >                  dependencies_satisfied = False
 >                  break
 >      if dependencies_satisfied:
 > -        current_status = job.run_test("kvm_runtest_2", params=dict, 
tag=dict.get("shortname"))
 >+        test_iterations=int(dict.get("iterations",1))

Please leave a space following a comma, here       ^

 >+        current_status = job.run_test("kvm_runtest_2", params=dict, 
tag=dict.get("shortname"),iterations=test_iterations)

Please use shorter lines.

 >     else:
 >         current_status = False
 >     status_dict[dict.get("name")] = current_status


Applied, with above mentioned changes.

Thanks,
     Uri.

  reply	other threads:[~2009-05-25 11:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <670003666.547921241172530227.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-05-01 10:13 ` [KVM-AUTOTEST] [PATCH] Iterate over reboot Michael Goldish
2009-05-04 12:08   ` supriya kannery
2009-05-25 11:21     ` Uri Lublin [this message]
2009-04-20 18:39 supriya kannery
2009-04-20 19:38 ` Ryan Harper
2009-04-22  7:54   ` supriya kannery
2009-04-22 14:47 ` Uri Lublin
2009-05-01  9:18   ` supriya kannery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1A7F35.8000600@redhat.com \
    --to=uril@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mgoldish@redhat.com \
    --cc=supriyak@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.