From: Avi Kivity <avi@redhat.com>
To: todd@fries.net
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] Do we need CONFIG_AIO?
Date: Mon, 25 May 2009 16:47:14 +0300 [thread overview]
Message-ID: <4A1AA162.1050403@redhat.com> (raw)
In-Reply-To: <20090525133554.GA16351@fries.net>
Todd T. Fries wrote:
> Penned by Stefano Stabellini on 20090525 12:49.08, we have:
> | Christoph Hellwig wrote:
> |
> | > Currently all aio code in the raw-posix block driver depends on a
> | > CONFIG_AIO symbol that gets set based on the availability of the
> | > pthreads library. Beeing able to rely on unconditional aio support
> | > means we could remove the whole code for plain bdrv_read/bdrv_write
> | > in raw-posix.c which is about 300 lines of code and a duplicated code
> | > path. Is there any Posix-ish platform qemu supports that does not
> | > have pthreads support?
> | >
> |
> | MiniOS.
> | I would appreciate if you keep that flag.
>
> You seem to be under the illusion that pthreads implies AIO.
>
He isn't.
> OpenBSD has two flavors of threads libraries (arguably one is not
> fit for consumption yet) and neither provide AIO.
>
> This flag is most useful for OpenBSD as well.
>
Qemu's CONFIG_AIO requires thread support from the host, not posix aio
support.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-25 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 8:21 [Qemu-devel] Do we need CONFIG_AIO? Christoph Hellwig
2009-05-25 11:49 ` Stefano Stabellini
2009-05-25 12:29 ` Christoph Hellwig
2009-05-25 12:58 ` Samuel Thibault
2009-05-25 13:00 ` Christoph Hellwig
2009-05-25 13:26 ` Stefano Stabellini
2009-05-25 13:35 ` Todd T. Fries
2009-05-25 13:40 ` Christoph Hellwig
2009-05-25 13:47 ` Avi Kivity [this message]
2009-05-25 15:24 ` Todd T. Fries
2009-05-25 15:27 ` Avi Kivity
2009-05-26 7:58 ` Anthony Liguori
2009-05-26 8:19 ` Christoph Hellwig
2009-05-26 10:02 ` Stefano Stabellini
2009-05-26 13:25 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1AA162.1050403@redhat.com \
--to=avi@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=todd@fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.