From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: Make paravirt tlb flush also reload PAE PDPTEs Date: Mon, 25 May 2009 18:09:17 +0300 Message-ID: <4A1AB49D.3060108@redhat.com> References: <1243241244-25953-1-git-send-email-avi@redhat.com> <1243241244-25953-2-git-send-email-avi@redhat.com> <20090525115933.GB3417@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45528 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbZEYPJR (ORCPT ); Mon, 25 May 2009 11:09:17 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4PF9Jbo005837 for ; Mon, 25 May 2009 11:09:19 -0400 In-Reply-To: <20090525115933.GB3417@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Mon, May 25, 2009 at 11:47:23AM +0300, Avi Kivity wrote: > >> The paravirt tlb flush may be used not only to flush TLBs, but also >> to reload the four page-directory-pointer-table entries, as it is used >> as a replacement for reloading CR3. Change the code to do the entire >> CR3 reloading dance instead of simply flushing the TLB. >> > > Ugh, my bad. > Not really -- the pvop is misleadingly named. -- error compiling committee.c: too many arguments to function