From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhai, Edwin" <edwin.zhai@intel.com>
Subject: Re: [patch] Fix xm pci-detach for inactive devices
Date: Tue, 26 May 2009 13:15:51 +0800
Message-ID: <4A1B7B07.1080709@intel.com>
References: <20090526043821.GA24218@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090526043821.GA24218@verge.net.au>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Simon Horman <horms@verge.net.au>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Masaki Kanno <kanno.masaki@jp.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

Simon,
What does inactive domain means?
How does it lead an invalid vslot?


Simon Horman wrote:
> In the case where a device is attached to an inactive domain
> and then removed before the domain is activated it won't have
> a vslot assigned, but it should still be valid to remove it.
>
> I don't think that there are any other cases where vslot can
> be invalid.
>
> Lightly tested
>
> Cc: Zhai Edwin <edwin.zhai@intel.com>
> Cc: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> Index: xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py
> ===================================================================
> --- xen-unstable.hg.orig/tools/python/xen/xend/XendDomainInfo.py	2009-05-26 14:37:15.000000000 +1000
> +++ xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py	2009-05-26 14:37:18.000000000 +1000
> @@ -1130,9 +1130,6 @@ class XendDomainInfo:
>          if devnum >= pci_len:
>              raise VmError("Device @ vslot 0x%x doesn't exist." % (vslot))
>  
> -        if vslot == AUTO_PHP_SLOT:
> -            raise VmError("Device @ vslot 0x%x doesn't support hotplug." % (vslot))
> -
>          # Check the co-assignment.
>          # To pci-detach a device D from domN, we should ensure: for each DD in the
>          # list of D's co-assignment devices, DD is not assigned (to domN).
>
>   

-- 
best rgds,
edwin