Re: [PATCH RFC v2 4/4] Use macro to iterate over vcpus.

[Avi Kivity <avi@redhat.com>]

Gleb Natapov wrote:
>  void kvm_arch_sync_events(struct kvm *kvm)
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 0934df3..34634e0 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -170,6 +170,17 @@ struct kvm {
>  #define kvm_printf(kvm, fmt ...) printk(KERN_DEBUG fmt)
>  #define vcpu_printf(vcpu, fmt...) kvm_printf(vcpu->kvm, fmt)
>  
> +static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i)
> +{
> +	smp_rmb();
> +        return kvm->vcpus[i];	
> +}
>   

Whitespace.

> +
> +#define kvm_for_each_vcpu(idx, vcpup, kvm) \
> +	for (idx = 0, vcpup = kvm_get_vcpu(kvm, idx); \
> +	     idx < atomic_read(&kvm->online_vcpus) && vcpup; \
> +	     vcpup = kvm_get_vcpu(kvm, ++idx))
> +	
>   
This will stop when reaching the first empty vcpu slot, while current 
code skips over empty slots.  Please preserve existing behaviour.



-- 
error compiling committee.c: too many arguments to function