From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC v2 2/4] Use pointer to vcpu instead of vcpu_id in timer code. Date: Tue, 26 May 2009 11:30:21 +0300 Message-ID: <4A1BA89D.8090003@redhat.com> References: <1243266636-16914-1-git-send-email-gleb@redhat.com> <1243266636-16914-3-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47962 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930AbZEZIaW (ORCPT ); Tue, 26 May 2009 04:30:22 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4Q8UONl032285 for ; Tue, 26 May 2009 04:30:24 -0400 In-Reply-To: <1243266636-16914-3-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/i8254.c | 2 +- > arch/x86/kvm/kvm_timer.h | 2 +- > arch/x86/kvm/lapic.c | 2 +- > arch/x86/kvm/timer.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c > index bcf755f..85d95ff 100644 > --- a/arch/x86/kvm/i8254.c > +++ b/arch/x86/kvm/i8254.c > @@ -291,7 +291,7 @@ static void create_pit_timer(struct kvm_kpit_state *ps, u32 val, int is_period) > pt->timer.function = kvm_timer_fn; > pt->t_ops = &kpit_ops; > pt->kvm = ps->pit->kvm; > - pt->vcpu_id = 0; > + pt->vcpu = pt->kvm->bsp_vcpu; > > bsp_vcpu might not have been initialized at this time? -- error compiling committee.c: too many arguments to function