From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id. Date: Tue, 26 May 2009 11:57:25 +0300 Message-ID: <4A1BAEF5.1020903@redhat.com> References: <1243266636-16914-1-git-send-email-gleb@redhat.com> <1243266636-16914-4-git-send-email-gleb@redhat.com> <4A1BA979.4010808@redhat.com> <20090526085503.GP3948@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45070 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609AbZEZI50 (ORCPT ); Tue, 26 May 2009 04:57:26 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4Q8vSJo006440 for ; Tue, 26 May 2009 04:57:28 -0400 In-Reply-To: <20090526085503.GP3948@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: >> Don't the vcpu ioctls need to be updated? They get the vcpu id as a >> parameter. >> >> > Are you sure they do? vcpu ioctls are issued on vcpu fd, no need to pass > vcpu id as a parameter. > > You're right, I was confused with an earlier version of the interface, and with libkvm. Moral: handle-based design = good. -- error compiling committee.c: too many arguments to function