From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 26 May 2009 12:30:26 +0000 Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64 Message-Id: <4A1BE0E2.3090306@redhat.com> List-Id: References: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com> In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jes Sorensen wrote: > Ok, > > Trying once more. After spending a couple of hours trying to follow > the QEMU dma codeflow, I have convinced myself Avi is right and those > two functions don't need to do the flushing as they all end up calling > dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a couple > comments to the code, which will hopefully save the next person the > 'pleasure' of trying to figure out this too. > It looks right to me. Xiantao? > access_len -= l; > - } > + } > + dma_flush_range((unsigned long)buffer, > + (unsigned long)buffer + flush_len); > } > Detab your code, please. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64 Date: Tue, 26 May 2009 15:30:26 +0300 Message-ID: <4A1BE0E2.3090306@redhat.com> References: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com> <4A0807DC.6080109@redhat.com> <4A1A8015.8080908@redhat.com> <4A1A9951.5030408@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" , Hollis Blanchard To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36932 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753911AbZEZMaa (ORCPT ); Tue, 26 May 2009 08:30:30 -0400 In-Reply-To: <4A1A9951.5030408@sgi.com> Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: > Ok, > > Trying once more. After spending a couple of hours trying to follow > the QEMU dma codeflow, I have convinced myself Avi is right and those > two functions don't need to do the flushing as they all end up calling > dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a couple > comments to the code, which will hopefully save the next person the > 'pleasure' of trying to figure out this too. > It looks right to me. Xiantao? > access_len -= l; > - } > + } > + dma_flush_range((unsigned long)buffer, > + (unsigned long)buffer + flush_len); > } > Detab your code, please. -- error compiling committee.c: too many arguments to function