From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines
Date: Tue, 26 May 2009 15:59:18 +0300 [thread overview]
Message-ID: <4A1BE7A6.6030108@redhat.com> (raw)
In-Reply-To: <4A1BE3F2.9010400@siemens.com>
Jan Kiszka wrote:
>>> +
>>> +#ifndef MCG_CTL_P
>>> +#define MCG_CTL_P (1ULL<<8)
>>> +#define MCG_STATUS_MCIP (1ULL<<2)
>>> +#define MCI_STATUS_VAL (1ULL<<63)
>>> +#define MCI_STATUS_OVER (1ULL<<62)
>>> +#define MCI_STATUS_UC (1ULL<<61)
>>> +#endif
>>>
>>>
>>>
>> This breaks on recent kernels (redefinition), so I removed it. Suggest
>> adding an include-compat/asm-x86/asm/mce.h and including that.
>>
>
> Non-empty mce.h will not work (but a patch to add an empty one was
> missing from my queue) - new kernel have that file, but with improper
> definitions for 32-bit. But what was that recent kernel and what was the
> precise problem?
2.6.27, those defines were redefined (by the subsequent include of mce.h)
> ATM I could only imagine that the block above is
> included before original mce.h, right? Then adding an explicit include
> here should cure the problem.
>
Yes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-26 12:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 11:52 [PATCH 0/8] kvm-kmod: Compat fixes & enhancements Jan Kiszka
2009-05-26 11:52 ` [PATCH 1/8] kvm-kmod: Allow to override sync source Jan Kiszka
2009-05-26 11:52 ` [PATCH 2/8] kvm-kmod: Include asm/uaccess.h on pre-2.6.18 kernels Jan Kiszka
2009-05-26 11:52 ` [PATCH 3/8] kvm-kmod: Include relayfs_fs.h on pre-2.6.17 kernels Jan Kiszka
2009-05-26 11:52 ` [PATCH 6/8] kvm-kmod: Add eventfd.c to patch list Jan Kiszka
2009-05-26 11:52 ` [PATCH 5/8] kvm-kmod: Fix msi_enabled patching Jan Kiszka
2009-05-26 11:52 ` [PATCH 4/8] kvm-kmod: Provide flush_work compat wrapper Jan Kiszka
2009-05-26 11:52 ` [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines Jan Kiszka
2009-05-26 12:08 ` Avi Kivity
2009-05-26 12:43 ` Jan Kiszka
2009-05-26 12:59 ` Avi Kivity [this message]
2009-05-26 13:47 ` [PATCH v2] " Jan Kiszka
2009-05-26 13:51 ` Avi Kivity
2009-05-26 11:52 ` [PATCH 7/8] kvm-kmod: x86: Add MSR_IA32_TSC compat define Jan Kiszka
2009-05-26 12:29 ` Jaswinder Singh Rajput
2009-05-26 12:36 ` Jan Kiszka
2009-05-26 12:42 ` Avi Kivity
2009-05-26 12:53 ` Jan Kiszka
2009-05-26 12:58 ` Avi Kivity
2009-05-26 12:48 ` Jaswinder Singh Rajput
2009-05-26 12:01 ` [PATCH 0/8] kvm-kmod: Compat fixes & enhancements Avi Kivity
2009-05-26 12:54 ` [PATCH] kvm-kmod: x86: Add MSR_K8_SYSCFG compat define Jan Kiszka
2009-05-26 21:01 ` [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat definition Jan Kiszka
2009-05-27 9:27 ` Avi Kivity
2009-05-27 9:55 ` Jaswinder Singh Rajput
2009-05-27 10:05 ` Jan Kiszka
2009-05-27 11:06 ` Jaswinder Singh Rajput
2009-05-27 11:12 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1BE7A6.6030108@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.