All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [Patch][BIOS] fix trying to boot from next device
Date: Tue, 26 May 2009 22:55:36 +0900	[thread overview]
Message-ID: <4A1BF4D8.6010505@jp.fujitsu.com> (raw)

Hi,

If boot="ndc", rombios cannot try to boot next device.
Because rombios jump to the boot vector without pushing return address,
gPXE code and so on cannot return if it fail to boot.

This patch fixes this issue.

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Best Regards,

Akio Takebe

---
diff -r 145e49b8574c tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Tue May 19 23:44:28 2009 +0100
+++ b/tools/firmware/rombios/rombios.c  Tue May 26 22:50:33 2009 +0900
@@ -8362,8 +8362,8 @@ ASM_END
   /* Jump to the boot vector */
 ASM_START
     mov  bp, sp
-//    push cs
-//    push #int18_handler
+    push cs
+    push #int18_handler
     ;; Build an iret stack frame that will take us to the boot vector.
     ;; iret pops ip, then cs, then flags, so push them in the opposite order.
     pushf

                 reply	other threads:[~2009-05-26 13:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1BF4D8.6010505@jp.fujitsu.com \
    --to=takebe_akio@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.