All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.linux-foundation.org>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] cgroups: handle failure of cgroup_populate_dir() at  mount/remount
Date: Wed, 27 May 2009 09:07:31 +0800	[thread overview]
Message-ID: <4A1C9253.3060108@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830905261506x480f2167naf1034177bbc7036@mail.gmail.com>

Paul Menage wrote:
> On Fri, May 22, 2009 at 1:25 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> Hm, shouldn't we allow "noprefix" to be effective only agaisnt cpuset ?
>> I think it's just for backward-compatibility of cpuset.
>> (I don't like the option at all.)
> 
> Yes, exposing the "noprefix" option externally was one of the mistakes
> I made when developing cgroups.
> 
> It seems to me really unlikely that anyone is using "noprefix" for

And "noprefix" is not documented in cgroups.txt, so I guess not
many people know this option. Even libcgroup doesn't handle it.

> anything other than implicitly when mounting the "cpuset" filesystem.
> So I'd be inclined to just forbid it if we're mounting more than just
> the cpuset subsystem. A bit of a nasty abstraction violation, but it
> makes more sense overall. The only problem is that someone *might* be
> using it - do we have any way to determine how, and how big do they
> have to be before we care?
> 

I think we can never know..

  reply	other threads:[~2009-05-27  1:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22  3:00 [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount Li Zefan
2009-05-22  3:00 ` Li Zefan
2009-05-22  8:25 ` KAMEZAWA Hiroyuki
     [not found]   ` <20090522172545.1e5e5f81.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-05-22  8:35     ` Li Zefan
2009-05-26 22:06     ` Paul Menage
2009-05-22  8:35   ` Li Zefan
     [not found]     ` <4A1663C2.4080401-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-05-22  8:34       ` KAMEZAWA Hiroyuki
2009-05-22  8:34     ` KAMEZAWA Hiroyuki
2009-05-22  9:10       ` Dhaval Giani
     [not found]         ` <20090522091034.GC8696-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2009-05-25  9:14           ` Li Zefan
2009-05-25  9:14         ` Li Zefan
     [not found]           ` <4A1A6192.6050608-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-05-25  9:47             ` Dhaval Giani
2009-05-25  9:47           ` Dhaval Giani
     [not found]       ` <20090522173421.ecacb40e.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-05-22  9:10         ` Dhaval Giani
2009-05-26 22:06   ` Paul Menage
2009-05-27  1:07     ` Li Zefan [this message]
     [not found]       ` <4A1C9253.3060108-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-05-27  1:34         ` KAMEZAWA Hiroyuki
2009-05-27  1:34       ` KAMEZAWA Hiroyuki
2009-05-27  3:24         ` Li Zefan
     [not found]           ` <4A1CB266.8000400-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-05-27  6:16             ` KAMEZAWA Hiroyuki
2009-05-27  6:16           ` KAMEZAWA Hiroyuki
     [not found]         ` <20090527103404.81d3c1a4.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-05-27  3:24           ` Li Zefan
     [not found]     ` <6599ad830905261506x480f2167naf1034177bbc7036-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-27  1:07       ` Li Zefan
     [not found] ` <4A16153C.2080004-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-05-22  8:25   ` KAMEZAWA Hiroyuki
2009-05-25 13:17   ` Balbir Singh
2009-05-25 13:17 ` Balbir Singh
2009-05-26  1:24   ` Li Zefan
     [not found]   ` <20090525131753.GL4858-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-05-26  1:24     ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1C9253.3060108@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.