All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: David Aguilar <davvid@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
	johannes.schindelin@gmx.de, markus.heidelberg@web.de,
	nick@incise.org
Subject: Re: [PATCH 2/2] diff: generate prettier filenames when using	GIT_EXTERNAL_DIFF
Date: Wed, 27 May 2009 09:14:27 +0200	[thread overview]
Message-ID: <4A1CE853.9080305@viscovery.net> (raw)
In-Reply-To: <20090527070221.GC2986@gmail.com>

David Aguilar schrieb:
> On Wed, May 27, 2009 at 08:34:57AM +0200, Johannes Sixt wrote:
>> David Aguilar schrieb:
>>> +#include <libgen.h>
>> We don't have libgen.h on Windows :-( (at least not with my aging gcc
>> 3.something). Would you please open-code the call to basename()?
> 
> I don't know much about Windows.
> Do we need to check for \ in addition to /?

If the paths have been taken from the index or have passed through
get_pathspec or prefix_filename, then it is sufficient to check for '/'.
Otherwise, use is_dir_sep() (note it is a macro: don't call it like
is_dir_sep(*c++)).

-- Hannes

  reply	other threads:[~2009-05-27  7:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27  3:19 [PATCH 1/2] compat: add a mkstemps() compatibility function David Aguilar
2009-05-27  3:19 ` [PATCH 2/2] diff: generate prettier filenames when using GIT_EXTERNAL_DIFF David Aguilar
2009-05-27  5:17   ` David Aguilar
2009-05-27  6:34   ` Johannes Sixt
2009-05-27  6:37     ` David Aguilar
2009-05-27  7:02     ` David Aguilar
2009-05-27  7:14       ` Johannes Sixt [this message]
2009-05-27  8:20 ` [PATCH 1/2] compat: add a mkstemps() compatibility function Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1CE853.9080305@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=markus.heidelberg@web.de \
    --cc=nick@incise.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.