All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Lublin <uril@redhat.com>
To: David Huff <dhuff@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: kvm_autotest: dynamically load tests
Date: Wed, 27 May 2009 14:46:34 +0300	[thread overview]
Message-ID: <4A1D281A.7040401@redhat.com> (raw)
In-Reply-To: <1240955328-23358-1-git-send-email-dhuff@redhat.com>

David Huff wrote:
> looking for comments/feedback....
> 
> These relatively simple changes to kvm_runtest_2 will allow for the addition of new tests without having modifying kvm_runtest "code."  
> 
> One would just add a newtest.py file and update the config file.  This will simplify test development and make it easier to deploying new tests in an existing environment.
> 
> The patch looks for tests that are not statically defined in kvm_runtest_2.py in ./kvm-autotest/client/tests/kvm_runtest_2/kvm_tests/'testname'.py and dynamically loads a module with a corresponding method run_'testname' where testname is defined by the "type" parameter in the config file.


Hi David,

I'm not sure this patch-set makes development much easier, as it only saves 
adding one line (entry) in test_routines table, but is less flexible (e.g. force 
file-name and function-name of test routines).

Moving the test to a separate kvm_tests directory can be done without dynamic 
load of the tests.

I don't have strong feelings about it though.

What others think ?

Thanks,
     Uri.

  parent reply	other threads:[~2009-05-27 11:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 21:48 kvm_autotest: dynamically load tests David Huff
2009-04-28 21:48 ` [PATCH] Modified kvm_runtest_2.py to look for tests in kvm_tests/ David Huff
2009-05-27 11:58   ` Uri Lublin
2009-04-28 21:48 ` [PATCH] Added "stock" or existing test to ./kvm_tests/ David Huff
2009-04-28 21:48 ` [PATCH] removed old kvm_test.py, tests now in seprate subdir David Huff
2009-05-27 11:46 ` Uri Lublin [this message]
2009-05-27 12:14   ` kvm_autotest: dynamically load tests David Huff
2009-05-27 17:00     ` sudhir kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1D281A.7040401@redhat.com \
    --to=uril@redhat.com \
    --cc=dhuff@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.