Re: [PATCH 2/2] netfilter: conntrack: add support for DCCP handshake sequence to ctnetlink

[Patrick McHardy <kaber@trash.net>]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
>> Pablo Neira Ayuso wrote:
>>> --- a/net/netfilter/nf_conntrack_proto_dccp.c
>>> +++ b/net/netfilter/nf_conntrack_proto_dccp.c
>>> @@ -639,6 +639,8 @@ static int dccp_to_nlattr(struct sk_buff *skb,
>>> struct nlattr *nla,
>>>      NLA_PUT_U8(skb, CTA_PROTOINFO_DCCP_STATE, ct->proto.dccp.state);
>>>      NLA_PUT_U8(skb, CTA_PROTOINFO_DCCP_ROLE,
>>>             ct->proto.dccp.role[IP_CT_DIR_ORIGINAL]);
>>> +    NLA_PUT_U64(skb, CTA_PROTOINFO_DCCP_HANDSHAKE_SEQ,
>>> +            ct->proto.dccp.handshake_seq);
>> This should use big endian byteorder.
> 
> dccp_hdr_seq() returns a value in host byte order, which is used to
> assign the value to handshake_seq. So, we need to use cpu_to_be64() to
> convert the value to network byte order as other attributes in ctnetlink
> which are in network byte order, right? :)

Absolutely :)

> Patch attached.

Applied to nf-next, thanks.