From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9Ode-0007Fr-Bg for qemu-devel@nongnu.org; Wed, 27 May 2009 15:18:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9OdY-0007B2-UW for qemu-devel@nongnu.org; Wed, 27 May 2009 15:18:09 -0400 Received: from [199.232.76.173] (port=51338 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9OdY-0007An-R0 for qemu-devel@nongnu.org; Wed, 27 May 2009 15:18:04 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:63729) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9OdY-0000tP-3J for qemu-devel@nongnu.org; Wed, 27 May 2009 15:18:04 -0400 Message-ID: <4A1D91E3.6070502@weilnetz.de> Date: Wed, 27 May 2009 21:17:55 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add static to local machine declaration. References: <4A187026.2080700@mail.berlios.de> <4A1D50A0.9070207@us.ibm.com> In-Reply-To: <4A1D50A0.9070207@us.ibm.com> Content-Type: multipart/mixed; boundary="------------060602070907090600010605" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: QEMU Developers This is a multi-part message in MIME format. --------------060602070907090600010605 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Anthony Liguori schrieb: > Stefan Weil wrote: >> Variable akitapda_machine is only used locally, >> so the static attribute avoids a compiler warning. >> >> Signed-off-by: Stefan Weil >> > > This patch is whitespace broken as is two other patches I have in my > queue for you. Could you try using something like git-send-email? > > Regards, > > Anthony Liguori > Sorry, I am still a git-learner... The appended patch will work. Regards, Stefan Weil --------------060602070907090600010605 Content-Type: text/x-diff; name="0001-Add-static-to-local-machine-declaration.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Add-static-to-local-machine-declaration.patch" >>From 3c4e4df0b882fd553aa89616e5d3d08a7eca301c Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sat, 23 May 2009 23:49:14 +0200 Subject: [PATCH] Add static to local machine declaration. Variable akitapda_machine is only used locally, so the static attribute avoids a compiler warning. Signed-off-by: Stefan Weil --- hw/spitz.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index aa1487b..ef0bace 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -1041,7 +1041,7 @@ static void terrier_init(ram_addr_t ram_size, kernel_cmdline, initrd_filename, cpu_model, terrier, 0x33f); } -QEMUMachine akitapda_machine = { +static QEMUMachine akitapda_machine = { .name = "akita", .desc = "Akita PDA (PXA270)", .init = akita_init, -- 1.5.6.5 --------------060602070907090600010605--