All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Nielsen <a.nielsen@shikadi.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: Avoiding multiple calls to xt_target.checkentry
Date: Thu, 28 May 2009 09:07:04 +1000	[thread overview]
Message-ID: <4A1DC798.1090604@shikadi.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0905240933050.18758@fbirervta.pbzchgretzou.qr>

>> In other words, is there a function only called the first time the rule is
>> added by iptables?  Or should I be keeping track of that myself?
> 
> You forget that iptables does not add rules. It replaces entire tables,
> and to make that atomic, the new table is checked before the old one
> is released. And yes, you usually try to lookup a led trigger first
> before creating one, because there can be a table that calls -j LED
> twice.

Thanks for the explanation!  So - to get it straight in my mind - the
checkentry function will be called multiple times while the trigger exists,
but is the destroy function also called multiple times?  Or is checkentry
called whenever tables are created, but destroy only ever called once when the
table is removed for the last time?

Just trying to work out whether I need to avoid removing the LED trigger in
the destroy function as well.

Thanks again,
Adam.


  reply	other threads:[~2009-05-27 23:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24  1:46 Avoiding multiple calls to xt_target.checkentry Adam Nielsen
2009-05-24  7:34 ` Jan Engelhardt
2009-05-27 23:07   ` Adam Nielsen [this message]
2009-05-28 21:06     ` Jan Engelhardt
2009-06-03  9:25     ` Patrick McHardy
2009-06-03 11:03       ` Adam Nielsen
2009-11-05 15:00         ` Patrick McHardy
2009-11-05 18:40           ` Jan Engelhardt
2009-11-05 18:43             ` Patrick McHardy
2009-11-05 22:04           ` Adam Nielsen
2009-11-06 14:56             ` Patrick McHardy
2009-11-29  1:43               ` [PATCH] Add refcounts to LED target Adam Nielsen
2009-11-29 10:12                 ` Jan Engelhardt
2009-11-29 11:33                   ` Adam Nielsen
2009-11-29 15:49                     ` Jan Engelhardt
2009-12-01 10:05                       ` Patrick McHardy
2009-12-06 10:09                         ` Adam Nielsen
2009-12-06 13:24                           ` Patrick McHardy
2010-03-25 14:01                             ` Patrick McHardy
2010-03-25 14:05                               ` Jan Engelhardt
2010-03-25 14:08                                 ` Patrick McHardy
2010-03-27  4:05                                   ` Adam Nielsen
2010-03-27 11:15                                     ` Jan Engelhardt
2010-03-27 11:39                                       ` Adam Nielsen
2010-03-27 11:55                                         ` Jan Engelhardt
2010-03-28  1:25                                           ` [PATCH v2] " Adam Nielsen
2010-04-04 11:30                                             ` Jan Engelhardt
2010-04-07 16:15                                               ` Patrick McHardy
2010-04-08  3:03                                                 ` [PATCH v3] " Adam Nielsen
2010-04-08 11:33                                                   ` Patrick McHardy
2010-04-08 12:45                                                     ` Jan Engelhardt
2010-04-08 12:57                                                       ` Patrick McHardy
2010-04-08 23:06                                                         ` [PATCH v4] " Adam Nielsen
2010-04-09 14:52                                                           ` Patrick McHardy
2010-04-08 21:07                                                   ` [PATCH v3] " Florian Westphal
2010-04-08 22:45                                                     ` Adam Nielsen
2010-03-27 18:42                                     ` [PATCH] " Jan Engelhardt
2010-03-28  1:58                                       ` Adam Nielsen
2010-04-04 11:59                                         ` Jan Engelhardt
2010-04-08  3:15                                           ` input-layer LEDs as LED-class devices (was: Add refcounts to LED target) Adam Nielsen
2010-04-08  8:03                                             ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1DC798.1090604@shikadi.net \
    --to=a.nielsen@shikadi.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.