From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests 206: test for overflow in growfs size calculation
Date: Fri, 29 May 2009 09:56:12 -0500 [thread overview]
Message-ID: <4A1FF78C.7050406@sandeen.net> (raw)
In-Reply-To: <20090529145025.GA9205@infradead.org>
Christoph Hellwig wrote:
> On Thu, May 28, 2009 at 04:12:53PM -0500, Eric Sandeen wrote:
>> Test trim of last small AG for large filesystem resizes
>>
>> As reported at
>> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
>> this trimming may cause an overflow in the new size calculation.
>>
>> Patch to fix it, and testcase at
>> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193
>>
>> V2: now with proper expected (resized) output!
>
> This fails for me in really weird ways (Debian -testing, i386):
>
>
> --- 206.out 2009-05-29 14:44:54.000000000 +0000
> +++ 206.out.bad 2009-05-29 14:46:01.000000000 +0000
> @@ -1,30 +1,18 @@
> QA output created by 206
> === xfs_io ===
> +ftruncate: File too large
hm, 32-bit. crud. Should probably just restrict the test to 64-bit
systems, since we need a file > 16T.
What's weirder is that xfs_io shoulda caused an error and caused the
test to bail, I think.
As for the rest of it, I need better error handling I guess :)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-05-29 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 20:33 [PATCH] xfstests 206: test for overflow in growfs size calculation Eric Sandeen
2009-05-28 21:12 ` [PATCH V2] " Eric Sandeen
2009-05-29 14:50 ` Christoph Hellwig
2009-05-29 14:56 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1FF78C.7050406@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.