All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"David C. Hansen"
	<haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [RFC][PATCH 7/7][v2] Define clone_with_pids syscall
Date: Fri, 29 May 2009 16:01:50 -0400	[thread overview]
Message-ID: <4A203F2E.1060807@cs.columbia.edu> (raw)
In-Reply-To: <20090529193416.GB12597-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>



Sukadev Bhattiprolu wrote:
> Sukadev Bhattiprolu [sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org] wrote:
> | Oren Laadan [orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org] wrote:
> 
> I am not sure what the semantics should be for this case:
> 
> 	- checkpoint a process that is in level-3 pid namespace
> 	- restart in a level-2 or level-1 pid namespace
> 

Meaning: a container root was at level-3, so tasks in the container
were level-3 through level-(3+N), where N is the in-container depth
so to speak. Then it was restarted such that the base became level-2
or level-1.

I think we already covered this.

> clone_with_pids() will fail now since number of pids specified would
> be 4 but kernel expects only 2 or 3. mktree/restart program cannot
> figure out current nesting to trim the target-pids.
> 
> Should we remove the check of user-pids exceeding the current nesting
> level and simply ignore the pids from the older namespaces ?

It seems to me that the current behavior is correct: I can't think
of a case where trimming (silently) would make sense, or where
a program would end up giving more pids that it's nesting level.

Oren.

  parent reply	other threads:[~2009-05-29 20:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28  4:37 [RFC][PATCH 1/7][v2] Factor out code to allocate pidmap page Sukadev Bhattiprolu
     [not found] ` <20090528043748.GA16522-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28  4:38   ` [RFC][PATCH 2/7][v2] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-05-28  4:38   ` [RFC][PATCH 3/7][v2] Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
     [not found]     ` <20090528043834.GC16522-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 12:52       ` Serge E. Hallyn
2009-05-28 14:47       ` Oren Laadan
2009-05-28  4:38   ` [RFC][PATCH 4/7][v2] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-05-28  4:39   ` [RFC][PATCH 5/7][v2] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-05-28  4:39   ` [RFC][PATCH 6/7][v2] Define do_fork_with_pids() Sukadev Bhattiprolu
     [not found]     ` <20090528043929.GF16522-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 12:54       ` Serge E. Hallyn
2009-05-28 15:03       ` Oren Laadan
2009-05-28  4:39   ` [RFC][PATCH 7/7][v2] Define clone_with_pids syscall Sukadev Bhattiprolu
     [not found]     ` <20090528043945.GG16522-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 12:02       ` Matt Helsley
2009-05-28 15:01       ` Oren Laadan
     [not found]         ` <4A1EA73F.1080802-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-28 15:14           ` Serge E. Hallyn
     [not found]             ` <20090528151444.GA17772-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 17:01               ` Sukadev Bhattiprolu
     [not found]                 ` <20090528170103.GA26183-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 17:47                   ` Serge E. Hallyn
     [not found]                     ` <20090528174708.GA2236-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2009-05-28 18:00                       ` Sukadev Bhattiprolu
     [not found]                         ` <20090528180057.GA27191-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 23:45                           ` Oren Laadan
2009-05-28 17:30           ` Sukadev Bhattiprolu
     [not found]             ` <20090528173019.GB26183-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-28 23:47               ` Oren Laadan
     [not found]                 ` <4A1F228C.2020201-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-29  1:16                   ` Sukadev Bhattiprolu
2009-05-29  3:05                   ` Sukadev Bhattiprolu
     [not found]                     ` <20090529030558.GA2548-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-29  5:29                       ` Oren Laadan
     [not found]                         ` <20090529054645.GA3344@us.ibm.com>
     [not found]                           ` <20090529054645.GA3344-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-29  5:54                             ` Oren Laadan
     [not found]                               ` <4A1F78AF.6030404-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-29 17:06                                 ` Sukadev Bhattiprolu
     [not found]                                   ` <20090529170616.GA12597-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-29 19:34                                     ` Sukadev Bhattiprolu
     [not found]                                       ` <20090529193416.GB12597-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-29 20:01                                         ` Oren Laadan [this message]
     [not found]                                           ` <4A203F2E.1060807-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-29 21:19                                             ` Sukadev Bhattiprolu
     [not found]                                               ` <20090529211922.GC12597-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-29 21:32                                                 ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A203F2E.1060807@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.