From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Date: Fri, 29 May 2009 21:09:16 +0000 Subject: Re: [PATCH 6/9] swiotlb: use dma_to_phys and phys_to_dma Message-Id: <4A204EFC.501@goop.org> List-Id: References: <1243586643-5554-1-git-send-email-ian.campbell@citrix.com> <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> In-Reply-To: <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ian Campbell Cc: linux-kernel@vger.kernel.org, FUJITA Tomonori , Olaf Kirch , Greg KH , Tony Luck , Becky Bruce , Benjamin Herrenschmidt , Kumar Gala , x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org Ian Campbell wrote: > static dma_addr_t swiotlb_virt_to_bus(struct device *hwdev, > volatile void *address) > { > - return swiotlb_phys_to_bus(hwdev, virt_to_phys(address)); > + return phys_to_dma(hwdev, virt_to_phys(address)); > } > > void * __weak swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) > Does this need to be weak too? J From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from claw.goop.org (claw.goop.org [74.207.240.146]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.goop.org", Issuer "Goop.org CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 5C11DDDDFA for ; Sat, 30 May 2009 07:09:25 +1000 (EST) Message-ID: <4A204EFC.501@goop.org> Date: Fri, 29 May 2009 14:09:16 -0700 From: Jeremy Fitzhardinge MIME-Version: 1.0 To: Ian Campbell Subject: Re: [PATCH 6/9] swiotlb: use dma_to_phys and phys_to_dma References: <1243586643-5554-1-git-send-email-ian.campbell@citrix.com> <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> In-Reply-To: <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Cc: x86@kernel.org, Tony Luck , linux-ia64@vger.kernel.org, Olaf Kirch , Greg KH , linux-kernel@vger.kernel.org, FUJITA Tomonori , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ian Campbell wrote: > static dma_addr_t swiotlb_virt_to_bus(struct device *hwdev, > volatile void *address) > { > - return swiotlb_phys_to_bus(hwdev, virt_to_phys(address)); > + return phys_to_dma(hwdev, virt_to_phys(address)); > } > > void * __weak swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) > Does this need to be weak too? J From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbZE2VJ1 (ORCPT ); Fri, 29 May 2009 17:09:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751406AbZE2VJU (ORCPT ); Fri, 29 May 2009 17:09:20 -0400 Received: from claw.goop.org ([74.207.240.146]:35349 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbZE2VJT (ORCPT ); Fri, 29 May 2009 17:09:19 -0400 Message-ID: <4A204EFC.501@goop.org> Date: Fri, 29 May 2009 14:09:16 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Ian Campbell CC: linux-kernel@vger.kernel.org, FUJITA Tomonori , Olaf Kirch , Greg KH , Tony Luck , Becky Bruce , Benjamin Herrenschmidt , Kumar Gala , x86@kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 6/9] swiotlb: use dma_to_phys and phys_to_dma References: <1243586643-5554-1-git-send-email-ian.campbell@citrix.com> <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> In-Reply-To: <1243586643-5554-7-git-send-email-ian.campbell@citrix.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ian Campbell wrote: > static dma_addr_t swiotlb_virt_to_bus(struct device *hwdev, > volatile void *address) > { > - return swiotlb_phys_to_bus(hwdev, virt_to_phys(address)); > + return phys_to_dma(hwdev, virt_to_phys(address)); > } > > void * __weak swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) > Does this need to be weak too? J