From: Jiri Slaby <jirislaby@gmail.com>
To: vibi_sreenivasan@cms.com
Cc: Mimi Zohar <zohar@us.ibm.com>, Kylene Hall <kylene@us.ibm.com>,
Serge Hallyn <serue@us.ibm.com>,
Reiner Sailer <sailer@watson.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]:Return proper error value on failure of dentry_open
Date: Mon, 01 Jun 2009 09:41:25 +0200 [thread overview]
Message-ID: <4A238625.8060002@gmail.com> (raw)
In-Reply-To: <1243836708.2163.3.camel@system>
On 06/01/2009 08:11 AM, vibi sreenivasan wrote:
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -201,10 +201,10 @@ int ima_path_check(struct path *path, int mask)
> }
> out:
> mutex_unlock(&iint->mutex);
> - if (file)
> + if (IS_ERR(file))
> fput(file);
This makes no sense at all. If it is IS_ERR, i.e. some negative value,
you don't want to pass it to fput. 'if (file)' was perfectly correct.
next prev parent reply other threads:[~2009-06-01 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 6:11 [PATCH]:Return proper error value on failure of dentry_open vibi sreenivasan
2009-06-01 7:41 ` Jiri Slaby [this message]
2009-06-01 8:10 ` vibi sreenivasan
2009-06-01 8:27 ` [PATCH]:RESEND : Return " vibi sreenivasan
2009-06-01 8:39 ` Jiri Slaby
2009-06-02 5:21 ` Andrew Morton
2009-06-02 5:35 ` vibi sreenivasan
2009-06-01 20:37 ` [PATCH]:Return " Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A238625.8060002@gmail.com \
--to=jirislaby@gmail.com \
--cc=kylene@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sailer@watson.ibm.com \
--cc=serue@us.ibm.com \
--cc=vibi_sreenivasan@cms.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.