From: Jiri Slaby <jirislaby@gmail.com>
To: vibi_sreenivasan@cms.com
Cc: Mimi Zohar <zohar@us.ibm.com>, Kylene Hall <kylene@us.ibm.com>,
Serge Hallyn <serue@us.ibm.com>,
Reiner Sailer <sailer@watson.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eric Paris <eparis@redhat.com>
Subject: Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of dentry_open]
Date: Mon, 01 Jun 2009 11:59:44 +0200 [thread overview]
Message-ID: <4A23A690.6070504@gmail.com> (raw)
In-Reply-To: <1243849610.2234.3.camel@system>
On 06/01/2009 11:46 AM, vibi sreenivasan wrote:
>>>> mutex_unlock(&iint->mutex);
>>>> - if (file)
>>>> + if (!IS_ERR(file))
>>>> fput(file);
>>>
>>> No, IS_ERR won't catch NULL and there is 'file = NULL' on the
>>> dentry_open fail path.
> Can you please point out that line number in fs/open.c
Aha, you use linus's git. This has been fixed by
f06dd16a03f6f7f72fab4db03be36e28c28c6fd6
(IMA: Handle dentry_open failures)
in -next.
next prev parent reply other threads:[~2009-06-01 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 9:46 [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of dentry_open] vibi sreenivasan
2009-06-01 9:59 ` Jiri Slaby [this message]
2009-06-01 10:02 ` Jiri Slaby
2009-06-01 10:37 ` vibi sreenivasan
2009-06-01 14:45 ` Mimi Zohar
2009-06-02 5:44 ` vibi sreenivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A23A690.6070504@gmail.com \
--to=jirislaby@gmail.com \
--cc=eparis@redhat.com \
--cc=kylene@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sailer@watson.ibm.com \
--cc=serue@us.ibm.com \
--cc=vibi_sreenivasan@cms.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.