From: Mike McCormack <mikem@ring3k.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix a race between sky2_down and sky2_poll.
Date: Tue, 02 Jun 2009 15:29:50 +0900 [thread overview]
Message-ID: <4A24C6DE.1040301@ring3k.org> (raw)
In-Reply-To: <20090601210728.2be1a903@nehalam>
Stephen Hemminger wrote:
>> - /* Make sure no packets are pending */
>> - napi_synchronize(&hw->napi);
> Down is also used during suspend/resume and changing MTU so this needs
> more inspection.
Could it be that the real problem is with the non-SMP case for
napi_synchronize()? The comment in include/linux/netdevice.h claims
that napi_synchronize() "Waits till any outstanding processing
completes..." but the implementation for non-SMP is just a barrier()...
Mike
prev parent reply other threads:[~2009-06-02 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 1:40 [PATCH] Fix a race between sky2_down and sky2_poll Mike McCormack
2009-06-02 4:07 ` Stephen Hemminger
2009-06-02 6:29 ` Mike McCormack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A24C6DE.1040301@ring3k.org \
--to=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.