From: Johannes Sixt <j.sixt@viscovery.net>
To: David Aguilar <davvid@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org, peff@peff.net,
markus.heidelberg@web.de, jnareb@gmail.com
Subject: Re: [PATCH v7 3/3] diff: generate pretty filenames in prep_temp_blob()
Date: Tue, 02 Jun 2009 09:04:08 +0200 [thread overview]
Message-ID: <4A24CEE8.4090702@viscovery.net> (raw)
In-Reply-To: <1243758952-28972-3-git-send-email-davvid@gmail.com>
David Aguilar schrieb:
> Naturally, prep_temp_blob() did not care about filenames.
> As a result, GIT_EXTERNAL_DIFF and textconv generated
> filenames such as ".diff_XXXXXX".
>
> This modifies prep_temp_blob() to generate user-friendly
> filenames when creating temporary files.
>
> Diffing "name.ext" now generates "XXXXXX_name.ext".
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
This series (as per 003b33a from Junio's pu):
Tested-by: Johannes Sixt <j6t@kdbg.org> (Windows)
-- Hannes
next prev parent reply other threads:[~2009-06-02 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 8:35 [PATCH v7 1/3] compat: add a mkstemps() compatibility function David Aguilar
2009-05-31 8:35 ` [PATCH v7 2/3] compat: add a basename() " David Aguilar
2009-05-31 8:35 ` [PATCH v7 3/3] diff: generate pretty filenames in prep_temp_blob() David Aguilar
2009-06-02 7:04 ` Johannes Sixt [this message]
2009-06-01 2:03 ` [PATCH v7 1/3] compat: add a mkstemps() compatibility function Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A24CEE8.4090702@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=markus.heidelberg@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.