From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (tmp401) Fix off-by-one error in
Date: Tue, 02 Jun 2009 08:26:28 +0000 [thread overview]
Message-ID: <4A24E234.8020600@redhat.com> (raw)
In-Reply-To: <20090602081821.GA4546@ubuntu>
Good catch!
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 06/02/2009 10:18 AM, Andre Prendel wrote:
> This patch fixes an off-by-one error in chip detection output.
>
> I2C kind starts with 1, so this cannot be used directly as the array index.
>
> Signed-off-by: Andre Prendel<andre.prendel@gmx.de>
> ---
> --- linux-2.6.orig/drivers/hwmon/tmp401.c 2009-05-29 23:09:58.000000000 +0200
> +++ linux-2.6/drivers/hwmon/tmp401.c 2009-05-29 23:10:29.000000000 +0200
> @@ -576,7 +576,7 @@
> goto exit_remove;
> }
> dev_info(&client->dev, "Detected TI %s chip\n",
> - names[data->kind]);
> + names[data->kind - 1]);
>
> return 0;
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2009-06-02 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 8:18 [lm-sensors] [PATCH] hwmon: (tmp401) Fix off-by-one error in chip Andre Prendel
2009-06-02 8:26 ` Hans de Goede [this message]
2009-06-02 9:14 ` [lm-sensors] [PATCH] hwmon: (tmp401) Fix off-by-one error Andre Prendel
2009-06-02 9:55 ` [lm-sensors] [PATCH] hwmon: (tmp401) Fix off-by-one error in Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A24E234.8020600@redhat.com \
--to=hdegoede@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.