From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754370AbZFCFPW (ORCPT ); Wed, 3 Jun 2009 01:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751354AbZFCFPM (ORCPT ); Wed, 3 Jun 2009 01:15:12 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:63634 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750970AbZFCFPL (ORCPT ); Wed, 3 Jun 2009 01:15:11 -0400 Message-ID: <4A26072B.8040207@cn.fujitsu.com> Date: Wed, 03 Jun 2009 13:16:27 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Daisuke Nishimura CC: LKML , linux-mm , Andrew Morton , Balbir Singh , KAMEZAWA Hiroyuki , Paul Menage Subject: Re: [PATCH mmotm 1/2] memcg: add interface to reset limits References: <20090603114518.301cef4d.nishimura@mxp.nes.nec.co.jp> <20090603114908.52c3aed5.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20090603114908.52c3aed5.nishimura@mxp.nes.nec.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daisuke Nishimura wrote: > Setting mem.limit or memsw.limit to 0 has no meaning > in actual use(no process can run in such condition). > I wrote a test program that set mem.limit to 0 to test oom in memcg, and now it is in LTP, though I can modify it accordingly. > We don't have interface to reset mem.limit or memsw.limit now, > so let's reset the mem.limit or memsw.limit to default(unlimited) > when they are being set to 0. > The idea of having a way to set the limit to unlimited is good, but how about allow this by writing -1 to mem.limit? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 85E2E5F0003 for ; Wed, 3 Jun 2009 12:21:48 -0400 (EDT) Message-ID: <4A26072B.8040207@cn.fujitsu.com> Date: Wed, 03 Jun 2009 13:16:27 +0800 From: Li Zefan MIME-Version: 1.0 Subject: Re: [PATCH mmotm 1/2] memcg: add interface to reset limits References: <20090603114518.301cef4d.nishimura@mxp.nes.nec.co.jp> <20090603114908.52c3aed5.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20090603114908.52c3aed5.nishimura@mxp.nes.nec.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: LKML , linux-mm , Andrew Morton , Balbir Singh , KAMEZAWA Hiroyuki , Paul Menage List-ID: Daisuke Nishimura wrote: > Setting mem.limit or memsw.limit to 0 has no meaning > in actual use(no process can run in such condition). > I wrote a test program that set mem.limit to 0 to test oom in memcg, and now it is in LTP, though I can modify it accordingly. > We don't have interface to reset mem.limit or memsw.limit now, > so let's reset the mem.limit or memsw.limit to default(unlimited) > when they are being set to 0. > The idea of having a way to set the limit to unlimited is good, but how about allow this by writing -1 to mem.limit? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org