From: rgh <birrachiara@tin.it>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] sis190: fix gigabit negotiation
Date: Wed, 03 Jun 2009 08:15:16 +0200 [thread overview]
Message-ID: <4A2614F4.9050304@tin.it> (raw)
In-Reply-To: <20090602213857.GB26871@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Riccardo Ghetta <birrachiara@tin.it> :
>> Fixes an initialization error; the chip negotiates gigabit, but
>> the driver mistakenly handled it as 100Mb.
>
> Did you draw some inspiration from SiS own driver ? If so it would
> deserve to be quoted.
>
Yes, I looked at both sis and forcedeth drivers. I'll quote both.
> val has been read from the LPA register.
>
> s/ADVERTISE_NPAGE/LPA_NPAGE/ ?
Uhu, yes, sorry.
next prev parent reply other threads:[~2009-06-03 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 8:49 [PATCH 0/3] sis190 gigabit fixes(bug 9735,11149) and new phy Riccardo Ghetta
2009-06-02 9:52 ` [PATCH 1/3] sis190: add new phy found on asus F5 series laptops Riccardo Ghetta
2009-06-02 21:18 ` Francois Romieu
2009-06-03 6:10 ` rgh
2009-06-04 4:41 ` David Miller
2009-06-02 9:52 ` [PATCH 2/3] sis190: fix gigabit negotiation Riccardo Ghetta
2009-06-02 21:38 ` Francois Romieu
2009-06-03 6:15 ` rgh [this message]
2009-06-02 9:53 ` [PATCH 3/3] sis190: better message on unknown PHY Riccardo Ghetta
2009-06-02 21:43 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2614F4.9050304@tin.it \
--to=birrachiara@tin.it \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.