From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl Beldan Subject: Re: [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Date: Wed, 03 Jun 2009 14:42:02 +0200 Message-ID: <4A266F9A.9050503@gmail.com> References: <1243916337-29953-1-git-send-email-vapier@gentoo.org> <20090603102605.GB11507@sirena.org.uk> <4A266878.2070206@gmail.com> <20090603121513.GB25676@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f175.google.com (mail-ew0-f175.google.com [209.85.219.175]) by alsa0.perex.cz (Postfix) with ESMTP id 5501F2434A for ; Wed, 3 Jun 2009 14:41:41 +0200 (CEST) Received: by ewy23 with SMTP id 23so9881267ewy.32 for ; Wed, 03 Jun 2009 05:41:40 -0700 (PDT) In-Reply-To: <20090603121513.GB25676@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org, Mike Frysinger , Cliff Cai List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > On Wed, Jun 03, 2009 at 02:11:36PM +0200, Karl Beldan wrote: > >> These samples rates are supported by the codec, updating coeff_div >> would be a better move. > > It looks like the driver only supports a limited subset of the chip > features as it is - there's also comments saying it supports asymmetric > configurations but currently the driver only does symmetric record and > playback setups. True. The comment was from me. The codec supports these rates and the driver only needs little modification to support them (just update an array - coeff_div). Though this commit is better than nothing, updating coeff_div seems IMO the thing to do. This change being trivial, the commit feels like a feature cut. -- Karl