* [PATCH] burgundy: timeout message is off by one.
@ 2009-06-03 23:53 Roel Kluin
2009-06-03 22:11 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-06-03 23:53 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, Andrew Morton
Timeout message is off by one.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/ppc/burgundy.c b/sound/ppc/burgundy.c
index 45a7629..d2c0a4e 100644
--- a/sound/ppc/burgundy.c
+++ b/sound/ppc/burgundy.c
@@ -46,12 +46,12 @@ snd_pmac_burgundy_extend_wait(struct snd_pmac *chip)
timeout = 50;
while (!(in_le32(&chip->awacs->codec_stat) & MASK_EXTEND) && timeout--)
udelay(1);
- if (! timeout)
+ if (timeout < 0)
printk(KERN_DEBUG "burgundy_extend_wait: timeout #1\n");
timeout = 50;
while ((in_le32(&chip->awacs->codec_stat) & MASK_EXTEND) && timeout--)
udelay(1);
- if (! timeout)
+ if (timeout < 0)
printk(KERN_DEBUG "burgundy_extend_wait: timeout #2\n");
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] burgundy: timeout message is off by one.
2009-06-03 23:53 [PATCH] burgundy: timeout message is off by one Roel Kluin
@ 2009-06-03 22:11 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-06-03 22:11 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel, Andrew Morton
At Thu, 04 Jun 2009 01:53:21 +0200,
Roel Kluin wrote:
>
> Timeout message is off by one.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied now. Thanks.
Takashi
> ---
> diff --git a/sound/ppc/burgundy.c b/sound/ppc/burgundy.c
> index 45a7629..d2c0a4e 100644
> --- a/sound/ppc/burgundy.c
> +++ b/sound/ppc/burgundy.c
> @@ -46,12 +46,12 @@ snd_pmac_burgundy_extend_wait(struct snd_pmac *chip)
> timeout = 50;
> while (!(in_le32(&chip->awacs->codec_stat) & MASK_EXTEND) && timeout--)
> udelay(1);
> - if (! timeout)
> + if (timeout < 0)
> printk(KERN_DEBUG "burgundy_extend_wait: timeout #1\n");
> timeout = 50;
> while ((in_le32(&chip->awacs->codec_stat) & MASK_EXTEND) && timeout--)
> udelay(1);
> - if (! timeout)
> + if (timeout < 0)
> printk(KERN_DEBUG "burgundy_extend_wait: timeout #2\n");
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-03 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-03 23:53 [PATCH] burgundy: timeout message is off by one Roel Kluin
2009-06-03 22:11 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.