From: Patrick McHardy <kaber@trash.net>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [resend] Passive OS fingerprint xtables match.
Date: Thu, 04 Jun 2009 13:53:05 +0200 [thread overview]
Message-ID: <4A27B5A1.9050300@trash.net> (raw)
In-Reply-To: <20090604113723.GA13018@ioremap.net>
Evgeniy Polyakov wrote:
> Hi.
>
> On Wed, May 27, 2009 at 06:28:16PM +0200, Patrick McHardy (kaber@trash.net) wrote:
>>> You will find something like this in the syslog:
>>> Windows [2000:SP3:Windows XP Pro SP1, 2000 SP3]: 11.22.33.55:4024 ->
>>> 11.22.33.44:139 hops=4
>>> Linux [2.5:]: 1.2.3.4:44448 -> 11.22.33.44:22 hops=4
>> Please convert this to use nf_log_packet().
>
> That's hard - there is no hook number in the match function, so we do
> not really know if it is forward, input or prerouting.
This is really needed, spamming the ring buffer is not a good option.
I'd say just add the hook number to xt_match_param. Its a bit
inconsistent anyways that we're handing it to checkentry for
validation, but not to the match function.
next prev parent reply other threads:[~2009-06-04 11:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 9:53 [resend] Passive OS fingerprint xtables match Evgeniy Polyakov
2009-05-27 16:28 ` Patrick McHardy
2009-05-29 8:59 ` Evgeniy Polyakov
2009-05-29 9:49 ` Jan Engelhardt
2009-05-29 10:20 ` Evgeniy Polyakov
2009-06-02 12:40 ` Patrick McHardy
2009-06-04 11:37 ` Evgeniy Polyakov
2009-06-04 11:53 ` Patrick McHardy [this message]
2009-06-04 12:07 ` Evgeniy Polyakov
2009-06-04 12:11 ` Patrick McHardy
2009-06-04 13:11 ` Evgeniy Polyakov
2009-06-04 13:16 ` Patrick McHardy
2009-06-04 13:30 ` Jan Engelhardt
2009-06-04 13:35 ` Patrick McHardy
2009-06-04 14:50 ` Evgeniy Polyakov
2009-06-04 14:55 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A27B5A1.9050300@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.