From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Best way to submit this patch
Date: Thu, 04 Jun 2009 08:29:06 -0400 [thread overview]
Message-ID: <4A27BE12.6010305@ge.com> (raw)
In-Reply-To: <1244115734.1999.42.camel@mpfj-x64>
Mark Jackson wrote:
> I'm planning to submit a patch to add LCD support to the current main
> Denx (non-AVR32) git.
>
> It consists of the following changes:-
>
> cpu/at32ap/at32ap700x/clk.c | 5 +
> cpu/at32ap/at32ap700x/portmux.c | 90
> +++++++++++++++++++++
> drivers/video/atmel_lcdfb.c | 5 +-
> include/asm-avr32/arch-at32ap700x/chip-features.h | 5 +
> include/asm-avr32/arch-at32ap700x/clk.h | 6 ++
> include/asm-avr32/arch-at32ap700x/portmux.h | 5 +-
> include/asm-avr32/global_data.h | 3 +
> include/lcd.h | 2 +-
> lib_avr32/board.c | 11 +++
> 9 files changed, 128 insertions(+), 4 deletions(-)
>
> Can I submit this as a single patch (since it is *all* related to LCD
> support), or should I split it up into lots of little patches ?
>
> Regards
> Mark
Hi Mark,
Don't agonize over it, just post the patch. The number of electrons you
kill by asking for direction/permission is roughly the same as the
number you kill by just submitting the patch. Just hit send already.
(Based on the above stats, that is a small patch. Hypothetically, it is
cohesive as well. We have insufficient information to throw any
hypothetical stones at it.)
Best regards,
gvb
next prev parent reply other threads:[~2009-06-04 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 11:42 [U-Boot] Best way to submit this patch Mark Jackson
2009-06-04 12:29 ` Jerry Van Baren [this message]
2009-06-04 13:46 ` Mark Jackson
2009-06-04 13:52 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A27BE12.6010305@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.